Added error parsing to cause project recreation on 404 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The request function now returns a custom error type `ResourceNotFoundError` * A test has been added
|
I modified the |
|
Resolves #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a big fan of string parsing for error handling, but this was the best way I could resolve issue #68 without changing the client as I understand it.
This change parses for 404s on project reads. If a 404 is returned, the project ID will be set to an empty string triggering a project recreation and a message from Terraform notifying of the change made outside of Terraform.
If this change is okay, I believe it also needs to be added to the update method and potentially all the other resources as I do not see 404 handling.